Naming variables and functions

TSjunior

There's an empty file on main — a colleague is creating a new utility. They've sent a PR that adds a function to total paid orders and some sample data. Your job is to read the diff and find the naming problems.

PR: lesson.typescript +15 −06 проблем

1-// orders.ts — pending first implementation

1+function calc(arr: any[]) {

2+ let x = 0

3+ const tmp = arr.filter((i) => i.s === 1)

4+ for (const d of tmp) {

5+ x += d.v

6+ }

7+ return x

8+}

9+

10+const data = [

11+ { s: 1, v: 100 },

12+ { s: 0, v: 50 },

13+ { s: 1, v: 200 },

14+]

15+

16+console.log(calc(data))

Шаг 1 из 8

Read the PR top to bottom

Before hunting for specific problems, read the whole file beginning to end. Ask yourself three questions: 1. What does this code do? 2. Did I understand its purpose in 10 seconds of reading? 3. Which words sound vague? If after 10 seconds you're still thinking "what is happening here?" — there are naming problems. Click "Next step" when you're ready.

ArchCase

ArchCase

Naming variables and functions

Read the PR top to bottom