Loading…
Loading…
First review lesson: learning to spot bad names for variables, functions, and constants. A small PR, a lot of problems.
Learning to spot forgotten imports, unused variables, and commented-out code — the most common noise in junior PRs.
Learning to spot nameless numeric and string constants that turn code into a puzzle six months later.
Learning to spot code that crashes on `null`, `undefined`, empty arrays, and other "edge" values — the biggest source of prod bugs in junior PRs.
JavaScript forgives bad code for too long — until it crashes in production on `0`, an empty string, or `[]`. Learning to spot these traps.
Green tests are an illusion of safety. Learning to tell real behavior tests from decorative tests that are "always green".