ArchCase

Design · Practice · Interview

Главная

Туториалы

Карточки

Loading…

Dead code: unused imports and variables

TSjunior

Практика →

Main already had a simple utility for formatting prices and receipt dates. A colleague sent a PR extending it. But in the middle of the refactor, some traces were left behind — unused imports, temporary variables, commented-out code. Your job is to walk the diff and find everything redundant before approving.

PR: lesson.typescript +9 −05 проблем

1-import { format, parseISO } from 'date-fns'

2-import { CURRENCY_SYMBOLS } from './constants'

1+import { format, parseISO, addDays } from 'date-fns'

2+import { CURRENCY_SYMBOLS, TAX_RATE } from './constants'

3+import type { Order, User } from './types'

45 export function formatPrice(amount: number, currency: string): string {

56 const symbol = CURRENCY_SYMBOLS[currency] ?? '$'

6- return `${symbol}${amount.toFixed(2)}`

7+ const oldFormat = `${amount} ${currency}` // legacy, delete later

8+ const result = `${symbol}${amount.toFixed(2)}`

9+ return result

710 }

811

12+// export function formatPriceWithTax(amount: number) {

13+// return formatPrice(amount * (1 + TAX_RATE), 'USD')

14+// }

15+

916 export function formatReceiptDate(iso: string): string {

10- return format(parseISO(iso), 'dd MMM yyyy')

17+ const date = parseISO(iso)

18+ const tomorrow = addDays(date, 1)

19+ return format(date, 'dd MMM yyyy')

1120 }

Шаг 1 из 7

Read the code in full

Before hunting for problems, read the file from start to finish. Your job here is to notice the "traces" in the code — traces of refactoring, temporary variables, commented-out pieces. Hint: pay attention to the imports. They're often where unused things show up first.