== vs === and truthy/falsy traps

JSПрактика

New file in the project — a colleague is creating a utility for filtering products and checking stock. It passes the tests, but it already crashed in prod on "weird" products. Walk the diff and find every loose-equality and truthy/falsy trap.

Клик по строке diff — напиши свой комментарий. Когда закончишь, жми «Отправить ревью».Туториал этого урока

1-// products-utils.js — new file

1+export function filterValidProducts(products) {

2+ return products.filter((p) => {

3+ if (p.available == true) {

4+ if (p.price && p.name) {

5+ if (p.discount != null) {

6+ return p.price - p.discount > 0

7+ }

8+ return true

9+ }

10+ }

11+ return false

12+ })

13+}

14+

15+export function hasStock(product) {

16+ return product.stock ? 'yes' : 'no'

17+}

0 комментариев

ArchCase

ArchCase

== vs === and truthy/falsy traps